Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add switch for local rpc enabled #37973

Merged

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Nov 25, 2024

issue: #33285
pr: #37985

  • Add switch for local rpc

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 25, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Nov 25, 2024
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement labels Nov 25, 2024
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (95a2ea6) to head (061b057).
Report is 4 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/coordinator/coordclient/registry.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.5   #37973   +/-   ##
=======================================
  Coverage   81.02%   81.03%           
=======================================
  Files        1360     1360           
  Lines      190664   190676   +12     
=======================================
+ Hits       154478   154505   +27     
+ Misses      30688    30678   -10     
+ Partials     5498     5493    -5     
Components Coverage Δ
Client 72.16% <ø> (ø)
Core 68.87% <ø> (ø)
Go 83.19% <75.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
pkg/util/paramtable/component_param.go 98.36% <100.00%> (+<0.01%) ⬆️
internal/coordinator/coordclient/registry.go 88.46% <0.00%> (-3.54%) ⬇️

... and 29 files with indirect coverage changes

@chyezh chyezh force-pushed the enhance_merge_all_coord_into_one_2_5 branch from 422a968 to 5ea70da Compare November 25, 2024 06:31
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 25, 2024

rerun go-sdk

@chyezh
Copy link
Contributor Author

chyezh commented Nov 25, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh chyezh force-pushed the enhance_merge_all_coord_into_one_2_5 branch from 5ea70da to 7e47752 Compare November 25, 2024 08:46
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 25, 2024

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented Nov 25, 2024

rerun go-sdk

Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Nov 25, 2024
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@chyezh chyezh force-pushed the enhance_merge_all_coord_into_one_2_5 branch from f2d16af to 061b057 Compare November 26, 2024 01:21
@mergify mergify bot added the ci-passed label Nov 26, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chyezh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 73bab0f into milvus-io:2.5 Nov 26, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants